]> dgit.raspbian.org Git - gnome-shell.git/commit
dbusServices/notifications: Stop broadcasting signals
authorFlorian Müllner <fmuellner@gnome.org>
Thu, 3 Feb 2022 00:32:55 +0000 (01:32 +0100)
committerMarge Bot <marge-bot@gnome.org>
Sat, 5 Feb 2022 12:17:23 +0000 (12:17 +0000)
commit0cbab09044a38ec60ca3f4f3798911da8f97bdf4
tree1f40d7c793393d76c4c571317b1b86d1295ce1c0
parent4de96ac737543df1b98ee551d11418263b35c424
dbusServices/notifications: Stop broadcasting signals

All fd.o Notifications signals are emitted for a particular notification,
so debugging aside, only the owner of said notification has a legitimate
reason to act on it.

So far we (and other implementations like the old notification-daemon)
have relied on the client-side to properly filter the signals (like
libnotify), but at least the QT implementation is known to not do
that.

Enforce correct client behavior by only emitting the signal to the
original sender.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5008

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2153>
js/dbusServices/notifications/notificationDaemon.js